Remove outdated rust_2018_idioms enforcement #2837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `#deny[rust_2018_idiom]` tag was used to help move from Rust 2015 style code to 2018. We've already moved beyond that and clippy flags much more than that. Since these are now useless, this cleans up all instances in the code where we were using this tag. Signed-off-by: Sean McGinnis <[email protected]>
webern
approved these changes
Feb 28, 2023
bcressey
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
The
#![deny(rust_2018_idioms)]tag was used to help move from Rust 2015 style code to 2018. We've already moved beyond that and clippy flags much more than that. Since these are now useless, this cleans up all instances in the code where we were using this tag.Testing done:
Ran
cargo make checkto run lints and unit tests.Created an
aws-k8s-1.24image, deployed cluster, and verified everything came up fine and able to deploy a test workload.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.